Compose source body physics and enable tutorial static response

This commit is contained in:
UnixNight committed 2026-10-26 22:22:42 -04:00
1 parent df0263b26e
commit 35a2a66606
26 files changed
+1045 -18

No files matched your search

@@ -0,0 +1,92 @@
# Ordinary body and VR04 bridge review
2026-10-27 UTC. Independent read-only review of primary's current
OriginalBodyPhysics.cs, LabSimulation.cs and Program.cs against
[the source contract](collision-body-composition-source.md). This investigator
owns only this report. No new original execution or REA session was necessary;
existing retained body/radius Evidence and guards establish the reviewed facts.
## Result
No directly evidenced mismatch was found within the stated subset: enabled
integration/support/collision/world flags, prevent-lowering enabled, lower-edge
override disabled, ordinary Jimmy contacts, fixed factor1.265 and zero angular
velocity in the live bridge. The implemented composition preserves source
impulse→acceleration→gravity, positive-Y/full versus nonpositive-Y/horizontal-first
motion, terminal370 positive-Y clearing, support/landing order, independent
published160 friction gate and final suppression. Fresh per-body nearest context
agrees with the source world branch's explicit resets.
The absence of special Player374 behavior is enforced conservatively by rejecting
any source scene with potentially eligible special-contact material IDs. Omitting
the source Vec4 previous/live-root reentrancy test is justified only inside this
bounded no-root-changing-contact subset; the explanatory source comment says so.
Generic334 angle wrapping/transform behavior remains outside the zero-angular
bridge, and the component's nonzero-angular numeric fixtures use the original
probe's substituted Euler-add virtual rather than real source334 execution.
## Integration checks
- Program selects the source body only for actual VR04; lab/outside keep their
existing adapter. OriginalBodyPhysics rejects special-contact geometry and
StepOriginalPhysics rejects attaching the provisional dynamic resolver.
- The live radius passed to body/support is InteractionRadius. This correctly
incorporates burst100 and later wrapper restoration60, rather than retaining
the old capsule24 radius or treating100 as interaction-only. Constant75.9 is
a conversion between modern feet storage and actor root, not the solver's
variable support offset. Rendering's sole correction remains a modern policy.
- Physics still runs before Jimmy input/controller/fire. Grounded radius60 is
restored in the wrapper before ownership checks. Preparing a script clears
controller speed/velocity while preserving body published160, pending impulse
and independent acceleration. A new scene resets published speed separately.
- The bridge supplies zero angular velocity and derives the next state from
current actor root/velocity/acceleration/impulse/support/published speed each
body pass. Dropping the component's angular output does not lose live angular
state inside this declared zero-angular subset.
- Camera debug enable remains camera-only; the body's geometry and overhead
query do not use it. Modern noclip bypasses the body while enabled and resumes
it with cleared motion through the existing debug policy.
## Scope risks and next gates
1. **Prepared doors are not every original dynamic body.** Program rejects a
nonempty StaticSceneVisuals.DoorColliders sequence in the source subset. This
establishes only absence of those prepared doors. Actual VR04 entities include
3SOL,3ROC,3TRO and other classes; their complete original physical-list and
pair-collision eligibility is not closed by that check. Preserve the explicit
no-dynamic-body-pass limitation and recover source registry/flags before
claiming complete tutorial collision fidelity or extending the adapter.
2. **Modern noclip exit uses the old occupancy policy.** SetNoclip(false) still
checks SceneCollision.CanOccupy with capsule24/render-derived height. Source
body response can subsequently reposition a root that this debug test admitted.
The ordinary flight/return test does not establish radius60/100 admission at
walls or tight gaps. Keep this as a documented debug policy; a later source
occupancy check needs an explicit supported contract rather than silently
treating zero-motion dispatch as a complete overlap query.
3. **Initial/visual placement is still bounded.** SceneCollision.GroundHeight and
floor-derived rendering are used to initialize the modern bridge. The stable
VR04 root/sole tests verify port consistency, not original transform/pivot
equivalence. Source spawn/root settling and wrapper/base logical-to-render
synchronization remain separate comparisons.
4. **Shared dynamic context remains unimplemented.** Fresh source body contexts
must not later be reused for dynamic reclipping without the recovered reset/
last-polygon schedule. Special contact root writes require the source Vec4
publication condition; a generic wall reflection is not an adequate substitute.
5. **Gadget scope remains−1/3.** Source gadget7 has additional374 side effects;
source scooter uses another radius policy. The current bridge does not carry
those contracts into OriginalBodyPhysics. Future gadget-selection expansion
must restrict or implement them before broadening this solver's claim.
These are retained integration boundaries, not failures of the ten-reference
ordinary composition. They do not require changing the verified source arithmetic.
## Verification
`source scripts/env.sh && dotnet run --project tests/GamePort.BodyPhysicsTests --
../Original` passes20 groups independently during this review, logged to
artifacts/collision-integration/body-implementation-review-tests.log. Coverage
includes ten original copied-body references, positive/nonpositive split,
ceiling370, radius100 support, unclamped friction, actual VR04 root/visual
consistency, preparation/published speed, control-independent impulse, retained
flight/landing and ordinary noclip return. These are managed port checks;
primary's headless/native/GPU/whole-route results are recorded separately.