From 5569bc2b8bc3bfd53b847525ce8a02d3b98ea228 Mon Sep 17 00:00:00 2001 From: Cristian Cerroni Date: Fri, 13 Nov 2026 17:00:47 -0500 Subject: [PATCH] fix(01): CR-01 bind review digest to selected receipt bytes --- tests/test_fidelity_acceptance.py | 21 +++++++++++++++++++++ tools/recon/fidelity_acceptance.py | 7 ++++--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/tests/test_fidelity_acceptance.py b/tests/test_fidelity_acceptance.py index e69b74e..24a2816 100644 --- a/tests/test_fidelity_acceptance.py +++ b/tests/test_fidelity_acceptance.py @@ -156,6 +156,27 @@ class AcceptanceTests(unittest.TestCase): self.review['receipt_ids'] = ['different'] self.assertTrue(self.audit()['errors']) + def test_review_digest_binds_selected_filename_without_sidecar(self): + checkpoint = self.root / 'checkpoint' + (checkpoint / 'protocol').mkdir(parents=True) + (checkpoint / 'manifest.json').write_bytes(receipts.canonical_bytes( + dict(self.manifest, packages={}))) + (checkpoint / 'protocol/scenarios.json').write_bytes(receipts.canonical_bytes(self.protocol)) + selected = self.record_root / 'selected.json' + selected.write_bytes(receipts.canonical_bytes(self.record)) + sibling = self.record_root / 'receipt.json' + sibling.write_text('{"unrelated": true}') + (self.root / 'current.json').write_bytes(receipts.canonical_bytes( + {'receipts': [selected.relative_to(self.root).as_posix()]})) + for reviewed, expected_pending in ((sibling, True), (None, True), (selected, False)): + review = dict(self.review, receipt_sha256={} if reviewed is None else { + self.record['receipt_id']: receipts.identify_file(reviewed)['sha256']}) + (self.root / 'human-review.json').write_bytes(receipts.canonical_bytes(review)) + with mock.patch.object(self.api(), 'ready'), mock.patch.object(self.api(), '_bind'): + report = self.api().audit(checkpoint, self.root) + self.assertEqual(bool(report['human_needed']), expected_pending) + self.assertEqual(report['matrix']['accepted'], 1) + def test_actual_failed_linux_receipt_import_and_review_remains_open(self): source = ROOT / 'artifacts/fidelity/linux-current-receipts/linux-01-06-matrix-preflight-linux' if not source.exists(): diff --git a/tools/recon/fidelity_acceptance.py b/tools/recon/fidelity_acceptance.py index 2152d21..46f3372 100644 --- a/tools/recon/fidelity_acceptance.py +++ b/tools/recon/fidelity_acceptance.py @@ -130,16 +130,17 @@ def audit(checkpoint, results): paths = read_json(selection).get('receipts', []) if selection.exists() else [] if not isinstance(paths, list) or len(paths) > 120 or len(set(paths)) != len(paths): raise ValueError('Current receipt selection must be a bounded unique array') - records = [] + records, selected = [], [] for name in paths: path = contained_path(results, name) records.append((read_receipt(path), path.parent)) + selected.append(path) review_path = results / 'human-review.json' review = read_json(review_path) if review_path.exists() else {} # Bind review to actual receipt bytes, not just reusable labels. - for receipt, directory in records: + for (receipt, _), path in zip(records, selected): expected = review.get('receipt_sha256', {}).get(receipt['receipt_id']) - if expected != identify_file(directory / 'receipt.json')['sha256']: + if expected != identify_file(path)['sha256']: review = dict(review, checks={}) break return audit_records(read_json(root / 'protocol/scenarios.json'), manifest, records, review)