Restore turning clips and attach jetpack fire to full player transform

This commit is contained in:
UnixNight committed 2026-11-05 15:25:50 -05:00
1 parent fafb54730a
commit f0be8504dd
14 files changed
+362 -9

No files matched your search

+50
View File
@@ -0,0 +1,50 @@
# Turning animations and rotating jetpack fire
2026-11-05. User requests restoring turning animation and reports that jetpack
fire does not follow Jimmy's rotation. Movement/physics arithmetic is preserved.
## Changes and evidence
[Turning recovery](jimmy-turn-animation.md) records REA instruction evidence,
original addresses/offsets, source animation acceptance and supplied clip hashes.
`jimleft.ASE`/`jimright.ASE` each contain six original morph samples. They were
missing from default preparation and runtime pose/action mapping. Preparation
now exports them with jimstop's topology/UVs; the player loads LEFT/RIGHT, retains
the input-owned side field, and chooses the matching clip when grounded at
nonnegative speed≤10. Forward movement above10 retains RUN, negative travel keeps
the existing backpedal path, and takeoff/air/primary-action ownership takes
precedence. Repeated requests retain the same clip/time. Existing generic morph
loop timing remains its separately documented port policy.
The retained REA EXE disassembly Evidence
`ev_0d64cc58fa8f5573fc8e61e0f2c20e36288099212bd2257d3a3121361fd6c904`
also covers jetpack42204C..4220BC (file2204C..220BC): owner310 returns its root,
then effect314 copies it; owner328 returns full Euler, then effect32C copies it.
Focused instructions are retained in artifacts/jimmy-turn-fire/fire-follow.asm.
The old JetpackVisuals used a yaw-only matrix. It now samples the original fire
morph through the same model transform as Jimmy, including pitch/yaw/roll and the
shared local sole-alignment correction. That correction is explicitly modern;
sharing it preserves original relative attachment instead of leaving the flame
in another visual frame. Geometry, scale, timer, visibility and energy are not
retuned. Exact final OMT matrix decomposition/animation cadence remain open.
## Verification
New PlayerVisualTests exercise both source six-frame clips, pose selection,
left precedence, release/run/jump/primary ownership, actual morph advancement and
same-pose time continuity. Fire tests compare the actual vertex buffer through
three combined rotations/translations, preserve unit determinant, and verify
hidden/reset behavior. The former movement assertion requiring idle while turning
now expects the left clip.28 movement groups, original-data/Director regressions,
14 jetpack groups, the new visual groups and333 Python tests pass; build has zero
warnings/errors. The source turn guard passes. These are bounded source and port
checks, not whole-original gameplay or native Windows comparison.
Native/package validation is appended below when complete.
Native Linux GTX1070/private Xvfb replays pass the300-step right-mouse jetpack
sequence and both original turn-clip previews at1920×1080, zero Vulkan validation
errors. Forward/braking flame captures and the left clip were visually inspected;
flame orientation now follows the owner rather than remaining vertical. New
visual tests cover actual runtime pose selection as well as the sampled mesh.
Artifacts: artifacts/jimmy-turn-fire/window/. Native Windows and exact original
morph timing remain separate verification boundaries.