8.4 KiB
phase, fixed_at, review_path, iteration, findings_in_scope, fixed, skipped, status
| phase | fixed_at | review_path | iteration | findings_in_scope | fixed | skipped | status |
|---|---|---|---|---|---|---|---|
| 01-reproducible-fidelity-baseline | 2026-11-13T22:09:37Z | .planning/phases/01-reproducible-fidelity-baseline/01-REVIEW.md | 1 | 5 | 5 | 0 | all_fixed |
Phase 01: Code Review Fix Report
All five confirmed findings were fixed. Their logic changes require independent human/reviewer verification; automated results below establish the stated tooling contracts, never original/native gameplay acceptance. No runtime/gameplay source, original file, package bytes, review disposition, or phase state was changed.
| Finding | Status | Commit | Applied fix and regression |
|---|---|---|---|
| CR-01 | fixed: requires human verification | 5569bc2 |
Carry the actual selected receipt path into digest review. Two different sibling JSON files without a sidecar prove that only the selected file's digest satisfies the human finding; absent/unrelated digests leave findings pending. |
| CR-02 | fixed: requires human verification | bda35e5 |
Supply the complete checkpoint original file inventory, recompute its digest, and bind identity.executable.original_member plus size/header/hash to the exact pristine member. Original pre/post/package/resources require full baseline file records and digest. Positive original fixtures retain actual member/executable hashes; wrong executable/member and altered inventory records fail. Writable-copy post changes are separately identified and remain allowed. |
| CR-03 | fixed: requires human verification | 6e5ee0b |
Bind both lifetimes to the validated named identity.copy_pre record; retained lifetimes also require identity.retained_copy. Unknown hashes and hashes of launcher/package/other state records fail. Fixtures now retain distinct actual copy-state files. |
| WR-01 | fixed: requires human verification | 548c97a |
Assemble the existing validated ledger projection before review export, seal it at protocol/capability-ledger.json, and compare viewer current/history against it during readiness. Actual preparation-to-bundled-renderer regression retains the named current and superseded startup records; a sealed viewer missing history is rejected. |
| WR-02 | fixed: requires human verification | 2608517 |
Recover missing run.json only as aborted from the retained incomplete record. Preserve the raw initial bytes as an importable recovery-initial.json diagnostic artifact, retain session/start identity, remove initial placeholder end clocks, and reject captured promotion or launch-aligned events. Shared validation/import permits this open aborted record with absent end clocks. |
WR-01 has one additional positive regression commit, a821754, proving readiness
on a standalone copied checkpoint with no source Git checkout. No fix was skipped
or rolled back. Five finding commits plus this verification commit were made.
Modified source: tools/recon/fidelity_acceptance.py, fidelity_receipts.py,
fidelity_checkpoint.py, and scripts/collect-fidelity-windows.ps1. Tests:
tests/test_fidelity_acceptance.py, test_fidelity_scenarios.py,
test_fidelity_checkpoint.py, and fidelity-windows.Tests.ps1. Field contracts:
docs/evidence/checkpoint-session.md and windows-session.md. No new source file
or dependency was required.
Verification
All gates ran locally in the main checkout. The primary explicitly authorized
a temporary workflow.use_worktrees=false override. Its original absent setting
was restored without staging or committing it; the unused clean worktree was
removed before edits. Unrelated untracked tools.yaml remains unchanged. Normal
Git hooks ran for every commit. The WR-01 refinement was folded into its commit
before the primary's no-rebase steering arrived; subsequent history is preserved.
Logs are retained under ignored artifacts/fidelity/01-review-fixes/:
python-fidelity.log: all 189 fidelity regressions passed in 40.072 seconds. Initial sandbox execution hit eight loopback-socket permission errors; the successful scoped-escalation run permits only the local tests' necessary host operations. These were environment errors, not accepted failed tests.acceptance-final.log: 29 acceptance tests passed after the final standalone transfer regression was added. This includes the refined readiness path; these tests overlap the 189-test run and are not added to its count.node-viewer-direct.log: 27 actual Node behavior tests passed. On this hostnode --testreports an aggregate one-file result; direct execution supplied the explicit 27-test count. The preparation test also rendered the real bundled model with the bundled renderer and a DOM double, without claiming browser playback evidence.powershell.log: 18 package-free synthetic tooling checks passed under cached Linux-hosted PowerShell. This is not native Windows execution evidence.recovered-import.log: the actual incomplete-only PowerShell output passed shared validation and atomic import; accepted is false. Raw fixture output and imported bytes are retained in separatetest-windows-results/andtest-recovered-imports/namespaces.original-preservation.log: all 539 original files unchanged. The same inventory command passed after assembly as well; preparation independently checked the original inventory before and after copying.- Python parse checks and
git diff --checkpassed. The prior 13-minute full managed/GPU suite was not repeated because these changes touch tooling and evidence contracts only.
Fresh immutable checkpoint
The final checkpoint was assembled once, using unchanged existing
artifacts/fidelity/01-05-packages/{linux-x64,win-x64} bytes. The prior tree was
preserved at dist/fidelity/phase01-pre-review-48100025; the documented current
path remains dist/fidelity/phase01. No sealed member was patched after assembly.
Mutable results contain a fresh import of the existing failed Linux preflight
receipt and the unchanged pending human-review controls; no captured evidence was
invented. The former assembly remains historical evidence.
| Item | Identity/result |
|---|---|
| Current checkpoint | dist/fidelity/phase01 |
| Immutable members | 11001 |
| READY SHA-256 | 7ceebcb3a22549a59bb9f7032c5c686b4ca4d32cf7b6a7d934e12e37f05e7aba |
| Manifest SHA-256 | a4da759bb264d63b716a931ae3b16a410baf01e36a7b2696ae8ed5649f77f7a9 |
| Tool commit | a821754b6755151a0e33e4ac5065c8efd252b2e6 |
| Tool working-tree provenance | Tracked diff empty; dirty true solely from preserved untracked tools.yaml, identified by the manifest |
| Sealed runtime source | 446930d2a30d6d616c60ac5e59e4169a840bea09, dirty true |
| Runtime publish diff | 90cef95669caece53fe2d2c4736cf2ac05ed27f5d25ca03ab572589686bcb73d |
| Linux package tree | 124cf271e4952f3822eec5c24358447fcffc9e9e1803aded8d96d4d4472dc5a3 |
| Windows package tree | 335e5b75ec15c0fa904113d8b69d4f50e2cfa403f1f2f225353bd9e586322ef4 |
| Startup viewer projection | Two current and two historical records retained |
| Readiness | Exit 0, materials_ready: true, acceptance: human_needed |
| Strict acceptance | Exit 1, 0/120, no structural errors, all ten human findings pending |
prepare-checkpoint.log, readiness.json, acceptance.json, and
failed-linux-import.json retain the actual results. The readiness and acceptance
reports also reside under the current bundle's mutable results/ directory.
The ten pending findings remain A1, A2, EVID-02-unclassified,
EVID-04-unclassified, P1, P2, P3, browser, paired_review, and physical_input.
The host still lacks actual original/native Windows capture access and a usable
Linux display/audio session. Independent re-review and the primary's remaining
security/coverage gates precede any combined capture request.
This report is intentionally uncommitted for the primary workflow to review and commit. No push, package upload, original execution, or original write occurred.
Final artifact-boundary refinement
CR-03 independent re-review caught pathless hash-only named records. RED48fca0d reproduces fresh/retained missing-file, wrong-size and hash-only cases; GREEN02d182f validates actual named files inside scenario observation with an explicit root. All191 fidelity tests pass in43.355s; focused26 scenario/23 capture/29 acceptance checks pass. Independent reviewer confirms allfive findings fixed; security auditor closes22/22 planned threats. The earlier11001-file bundle is retained locally; current dist/fidelity/phase01 is freshly assembled from corrected source with original runtime package identities unchanged.