Files
Neutron/docs/checkpoint/collision-integration-review.md
T

4.0 KiB
Raw Blame History

C4 static dispatcher review

2026-10-26. Independent source review of the uncommitted static dispatcher, its managed fixtures, saved REA replies and retained original-component output. No original code was executed and no new REA session was opened by this review. File ownership for this report only; primary owns integration and corrections.

Findings and disposition

  • Corrected during review: TraceSupport initially accepted its first triangle hit without the source's initial nearest-distance limit. Retained REA support reply artifacts/collision-integration/rea-support/00.json, Evidence ev_ad96a93792dcf00534130fbd428fb52fa25e2cf9c2492df43f89f425b80c3f08, initializes47C6E0's nearest distance to quick_magnitude(end−start), then requires a strictly smaller hit magnitude. The kernel's parameter-distance check is separate from the returned hit's magnitude. Primary added that initial limit and strict comparison. This closes a source-contract omission; no original numeric boundary probe is claimed.
  • Corrected during review: old prepared meshes could omit material IDs and appear ordinary-only. Primary added explicit material-identity completeness metadata and a FromRouteScene rejection requiring newly prepared scenes. Resolved null-material identity remains distinct from missing metadata.
  • Corrected after review: Move now accepts the source geometry-enable state. Source47B4B0 reads4F69E5 per node, while its final publication and retained last-polygon callback can still occur when geometry is disabled. A caller must not equate disabling geometry with skipping Move when it reuses a context. The added regression checks publication and retained callback without primitive visits. Dynamic shared-state/reset timing remains a live gate.
  • Live integration gate: the dispatcher returns a candidate and terminal polygon; it does not publish the logical actor transform or execute callback 370/374, support, friction or speed publication. Jimmy ordinary374 must retain the special-material boundary. LV1B/LEV1 contain such materials; VR04's absence of them is a bounded route-data result, not a general player policy.
  • Documented port limits: iterative retry rejection after256 passes, finite inputs, triangular polygons and approximate x87 cell conversion are explicit boundaries. Do not promote this component to whole-body identity or claim the source has a recursion cap.

Verification

source scripts/env.sh && dotnet run --project tests/GamePort.StaticCollisionTests passed seven groups during review. The seven printed copied-original dispatcher cases in artifacts/collision-integration/dispatch/wine.log match the managed fixtures' positions, pass/visit counts and terminal polygon observations. The retained marker is DISPATCH_COMPONENT_COMPLETE; the reviewer did not rerun that probe. This verifies a bounded original component comparison, not live port gameplay. Primary's subsequent focused run passes eleven groups, adding actual prepared route material coverage, legacy metadata rejection, geometry-disabled retained context, equal support ties and zero-length limits. Full integration passes122 Python checks plus HUD/managed/GPU/audio/hash checks; see progress.md for scope.

Registration sorting, X-outer/Z-inner traversal, per-cell duplicate visits, frozen bounds including source MIN upper-Z, unchanged previous root across retries, persistent nearest state and terminal-only callback selection agree with collision-grid-traversal.md and its retained instruction/REA evidence.

Before enabling live body response, extend regression coverage to inherited nearest/last-polygon state across separate dynamic reclip calls, equal-distance support ties, and callback ownership/order after publication. Complete the source contact policies and route/root checks identified by the implementation ledger. After the stated review reset time, primary retried through normal approval review and completed the ten-fixture isolated body probe. This closes that execution blocker, but does not establish live whole-body equivalence.