docs(01): close review and security gates with acceptance pending
This commit is contained in:
1 parent
02d182f35d
commit
71366e7d45
14 files changed
+417
-77
No files matched your search
@@ -1,10 +1,12 @@
|
||||
<!-- CONSUMED: task3 recovered exit0 and review complete through02d182f. Current next action: final phase verification, then combined human session; never resume historical active test below. -->
|
||||
|
||||
---
|
||||
context: phase
|
||||
phase: 01-reproducible-fidelity-baseline
|
||||
plan: "07"
|
||||
task: 3
|
||||
total_tasks: 3
|
||||
status: paused
|
||||
status: consumed
|
||||
last_updated: "2026-11-13T17:28:45.982275+00:00"
|
||||
---
|
||||
|
||||
|
||||
@@ -190,3 +190,7 @@ All created source/test/checklist/baseline files, final local checkpoint, comple
|
||||
suite receipt and exact identity receipt exist. All five recorded commits are
|
||||
ancestors of the measured HEAD. Final readiness passes and strict audit retains
|
||||
errors=[], 0/120 and ten pending findings. Unrelated `tools.yaml` is preserved.
|
||||
|
||||
## Independent review closure
|
||||
|
||||
Five confirmed findings were fixed and independently verified; see01-REVIEW.md,01-FIX-REPORT.md,01-REVIEW-VERIFY.md and01-REVIEW-DISPOSITION.md. Final refinement02d182f requires actual artifact bytes at the scenario boundary;191 fidelity checks pass43.355s. The new checkpoint has11,001 immutable entries with current local identities in artifacts/fidelity/verification/01-07-final-checkpoint.json; prior identity notes remain historical. All22 planned security threats are closed, while actual0/120 acceptance and ten named human findings stayOPEN. No original/native acceptance or phase advancement is implied.
|
||||
@@ -0,0 +1,114 @@
|
||||
---
|
||||
phase: 01-reproducible-fidelity-baseline
|
||||
fixed_at: 2026-11-13T22:09:37Z
|
||||
review_path: .planning/phases/01-reproducible-fidelity-baseline/01-REVIEW.md
|
||||
iteration: 1
|
||||
findings_in_scope: 5
|
||||
fixed: 5
|
||||
skipped: 0
|
||||
status: all_fixed
|
||||
---
|
||||
|
||||
# Phase 01: Code Review Fix Report
|
||||
|
||||
All five confirmed findings were fixed. Their logic changes require independent
|
||||
human/reviewer verification; automated results below establish the stated tooling
|
||||
contracts, never original/native gameplay acceptance. No runtime/gameplay source,
|
||||
original file, package bytes, review disposition, or phase state was changed.
|
||||
|
||||
| Finding | Status | Commit | Applied fix and regression |
|
||||
|---|---|---|---|
|
||||
| CR-01 | fixed: requires human verification | `5569bc2` | Carry the actual selected receipt path into digest review. Two different sibling JSON files without a sidecar prove that only the selected file's digest satisfies the human finding; absent/unrelated digests leave findings pending. |
|
||||
| CR-02 | fixed: requires human verification | `bda35e5` | Supply the complete checkpoint original file inventory, recompute its digest, and bind `identity.executable.original_member` plus size/header/hash to the exact pristine member. Original pre/post/package/resources require full baseline file records and digest. Positive original fixtures retain actual member/executable hashes; wrong executable/member and altered inventory records fail. Writable-copy post changes are separately identified and remain allowed. |
|
||||
| CR-03 | fixed: requires human verification | `6e5ee0b` | Bind both lifetimes to the validated named `identity.copy_pre` record; retained lifetimes also require `identity.retained_copy`. Unknown hashes and hashes of launcher/package/other state records fail. Fixtures now retain distinct actual copy-state files. |
|
||||
| WR-01 | fixed: requires human verification | `548c97a` | Assemble the existing validated ledger projection before review export, seal it at `protocol/capability-ledger.json`, and compare viewer current/history against it during readiness. Actual preparation-to-bundled-renderer regression retains the named current and superseded startup records; a sealed viewer missing history is rejected. |
|
||||
| WR-02 | fixed: requires human verification | `2608517` | Recover missing `run.json` only as aborted from the retained incomplete record. Preserve the raw initial bytes as an importable `recovery-initial.json` diagnostic artifact, retain session/start identity, remove initial placeholder end clocks, and reject captured promotion or launch-aligned events. Shared validation/import permits this open aborted record with absent end clocks. |
|
||||
|
||||
WR-01 has one additional positive regression commit, `a821754`, proving readiness
|
||||
on a standalone copied checkpoint with no source Git checkout. No fix was skipped
|
||||
or rolled back. Five finding commits plus this verification commit were made.
|
||||
|
||||
Modified source: `tools/recon/fidelity_acceptance.py`, `fidelity_receipts.py`,
|
||||
`fidelity_checkpoint.py`, and `scripts/collect-fidelity-windows.ps1`. Tests:
|
||||
`tests/test_fidelity_acceptance.py`, `test_fidelity_scenarios.py`,
|
||||
`test_fidelity_checkpoint.py`, and `fidelity-windows.Tests.ps1`. Field contracts:
|
||||
`docs/evidence/checkpoint-session.md` and `windows-session.md`. No new source file
|
||||
or dependency was required.
|
||||
|
||||
## Verification
|
||||
|
||||
All gates ran locally in the **main checkout**. The primary explicitly authorized
|
||||
a temporary `workflow.use_worktrees=false` override. Its original absent setting
|
||||
was restored without staging or committing it; the unused clean worktree was
|
||||
removed before edits. Unrelated untracked `tools.yaml` remains unchanged. Normal
|
||||
Git hooks ran for every commit. The WR-01 refinement was folded into its commit
|
||||
before the primary's no-rebase steering arrived; subsequent history is preserved.
|
||||
|
||||
Logs are retained under ignored `artifacts/fidelity/01-review-fixes/`:
|
||||
|
||||
- `python-fidelity.log`: all 189 fidelity regressions passed in 40.072 seconds.
|
||||
Initial sandbox execution hit eight loopback-socket permission errors; the
|
||||
successful scoped-escalation run permits only the local tests' necessary host
|
||||
operations. These were environment errors, not accepted failed tests.
|
||||
- `acceptance-final.log`: 29 acceptance tests passed after the final standalone
|
||||
transfer regression was added. This includes the refined readiness path; these
|
||||
tests overlap the 189-test run and are not added to its count.
|
||||
- `node-viewer-direct.log`: 27 actual Node behavior tests passed. On this host
|
||||
`node --test` reports an aggregate one-file result; direct execution supplied
|
||||
the explicit 27-test count. The preparation test also rendered the real bundled
|
||||
model with the bundled renderer and a DOM double, without claiming browser
|
||||
playback evidence.
|
||||
- `powershell.log`: 18 package-free synthetic tooling checks passed under cached
|
||||
Linux-hosted PowerShell. This is not native Windows execution evidence.
|
||||
- `recovered-import.log`: the actual incomplete-only PowerShell output passed
|
||||
shared validation and atomic import; accepted is false. Raw fixture output and
|
||||
imported bytes are retained in separate `test-windows-results/` and
|
||||
`test-recovered-imports/` namespaces.
|
||||
- `original-preservation.log`: all 539 original files unchanged. The same
|
||||
inventory command passed after assembly as well; preparation independently
|
||||
checked the original inventory before and after copying.
|
||||
- Python parse checks and `git diff --check` passed. The prior 13-minute full
|
||||
managed/GPU suite was not repeated because these changes touch tooling and
|
||||
evidence contracts only.
|
||||
|
||||
## Fresh immutable checkpoint
|
||||
|
||||
The final checkpoint was assembled **once**, using unchanged existing
|
||||
`artifacts/fidelity/01-05-packages/{linux-x64,win-x64}` bytes. The prior tree was
|
||||
preserved at `dist/fidelity/phase01-pre-review-48100025`; the documented current
|
||||
path remains `dist/fidelity/phase01`. No sealed member was patched after assembly.
|
||||
Mutable results contain a fresh import of the existing failed Linux preflight
|
||||
receipt and the unchanged pending human-review controls; no captured evidence was
|
||||
invented. The former assembly remains historical evidence.
|
||||
|
||||
| Item | Identity/result |
|
||||
|---|---|
|
||||
| Current checkpoint | `dist/fidelity/phase01` |
|
||||
| Immutable members | 11001 |
|
||||
| READY SHA-256 | `7ceebcb3a22549a59bb9f7032c5c686b4ca4d32cf7b6a7d934e12e37f05e7aba` |
|
||||
| Manifest SHA-256 | `a4da759bb264d63b716a931ae3b16a410baf01e36a7b2696ae8ed5649f77f7a9` |
|
||||
| Tool commit | `a821754b6755151a0e33e4ac5065c8efd252b2e6` |
|
||||
| Tool working-tree provenance | Tracked diff empty; dirty true solely from preserved untracked `tools.yaml`, identified by the manifest |
|
||||
| Sealed runtime source | `446930d2a30d6d616c60ac5e59e4169a840bea09`, dirty true |
|
||||
| Runtime publish diff | `90cef95669caece53fe2d2c4736cf2ac05ed27f5d25ca03ab572589686bcb73d` |
|
||||
| Linux package tree | `124cf271e4952f3822eec5c24358447fcffc9e9e1803aded8d96d4d4472dc5a3` |
|
||||
| Windows package tree | `335e5b75ec15c0fa904113d8b69d4f50e2cfa403f1f2f225353bd9e586322ef4` |
|
||||
| Startup viewer projection | Two current and two historical records retained |
|
||||
| Readiness | Exit 0, `materials_ready: true`, `acceptance: human_needed` |
|
||||
| Strict acceptance | Exit 1, 0/120, no structural errors, all ten human findings pending |
|
||||
|
||||
`prepare-checkpoint.log`, `readiness.json`, `acceptance.json`, and
|
||||
`failed-linux-import.json` retain the actual results. The readiness and acceptance
|
||||
reports also reside under the current bundle's mutable `results/` directory.
|
||||
The ten pending findings remain A1, A2, EVID-02-unclassified,
|
||||
EVID-04-unclassified, P1, P2, P3, browser, paired_review, and physical_input.
|
||||
The host still lacks actual original/native Windows capture access and a usable
|
||||
Linux display/audio session. Independent re-review and the primary's remaining
|
||||
security/coverage gates precede any combined capture request.
|
||||
|
||||
This report is intentionally uncommitted for the primary workflow to review and
|
||||
commit. No push, package upload, original execution, or original write occurred.
|
||||
|
||||
## Final artifact-boundary refinement
|
||||
|
||||
CR-03 independent re-review caught pathless hash-only named records. RED48fca0d reproduces fresh/retained missing-file, wrong-size and hash-only cases; GREEN02d182f validates actual named files inside scenario observation with an explicit root. All191 fidelity tests pass in43.355s; focused26 scenario/23 capture/29 acceptance checks pass. Independent reviewer confirms allfive findings fixed; security auditor closes22/22 planned threats. The earlier11001-file bundle is retained locally; current dist/fidelity/phase01 is freshly assembled from corrected source with original runtime package identities unchanged.
|
||||
@@ -5,25 +5,25 @@ titles: json
|
||||
findings:
|
||||
- id: CR-01
|
||||
severity: critical
|
||||
disposition: open
|
||||
disposition: fixed
|
||||
title: "Human review is checked against a different file from the selected receipt"
|
||||
- id: CR-02
|
||||
severity: critical
|
||||
disposition: open
|
||||
disposition: fixed
|
||||
title: "Original applicability never binds the executed executable or preservation inventories"
|
||||
- id: CR-03
|
||||
severity: critical
|
||||
disposition: open
|
||||
disposition: fixed
|
||||
title: "Fresh-copy continuity accepts a hash that identifies no artifact"
|
||||
- id: WR-01
|
||||
severity: warning
|
||||
disposition: open
|
||||
disposition: fixed
|
||||
title: "Checkpoint assembly bypasses the capability ledger projection"
|
||||
- id: WR-02
|
||||
severity: warning
|
||||
disposition: open
|
||||
disposition: fixed
|
||||
title: "An interrupted Windows collector cannot be finalized through the documented recovery command"
|
||||
open: 5
|
||||
open: 0
|
||||
total: 5
|
||||
recorded: 2026-11-13T21:58:50.502559+00:00
|
||||
---
|
||||
@@ -32,8 +32,8 @@ recorded: 2026-11-13T21:58:50.502559+00:00
|
||||
|
||||
| Finding | Severity | Disposition | Source |
|
||||
|---|---|---|---|
|
||||
| CR-01 | critical | open | Reproduced; fix in progress |
|
||||
| CR-02 | critical | open | Reproduced; fix in progress |
|
||||
| CR-03 | critical | open | Reproduced; fix in progress |
|
||||
| WR-01 | warning | open | Reproduced; fix in progress |
|
||||
| WR-02 | warning | open | Reproduced; fix in progress |
|
||||
| CR-01 | critical | fixed | 01-REVIEW-VERIFY.md; independent re-review |
|
||||
| CR-02 | critical | fixed | 01-REVIEW-VERIFY.md; independent re-review |
|
||||
| CR-03 | critical | fixed | 01-REVIEW-VERIFY.md; independent re-review |
|
||||
| WR-01 | warning | fixed | 01-REVIEW-VERIFY.md; independent re-review |
|
||||
| WR-02 | warning | fixed | 01-REVIEW-VERIFY.md; independent re-review |
|
||||
@@ -0,0 +1,75 @@
|
||||
---
|
||||
phase: 01-reproducible-fidelity-baseline
|
||||
verified: 2026-11-13T22:19:18Z
|
||||
review_path: .planning/phases/01-reproducible-fidelity-baseline/01-REVIEW.md
|
||||
fix_report_path: .planning/phases/01-reproducible-fidelity-baseline/01-FIX-REPORT.md
|
||||
verified_head: 02d182f35de643f9d68699b2fff1d219dd132edb
|
||||
findings_verified: 5
|
||||
fixed: 5
|
||||
open: 0
|
||||
findings:
|
||||
critical: 0
|
||||
warning: 0
|
||||
info: 0
|
||||
total: 0
|
||||
status: clean
|
||||
---
|
||||
|
||||
# Phase 01 review-fix verification
|
||||
|
||||
All five fixes are verified. The final CR-03 refinement requires actual backing artifacts for named copy-state identities and rejects the hash-only records that survived its first fix. No reviewed finding remains open.
|
||||
|
||||
| Finding | Disposition | Independent verification |
|
||||
|---|---|---|
|
||||
| CR-01 | FIXED | The selected path is retained and its own digest is compared with the human finding. The sibling-digest and absent-digest regressions leave human checks pending; the actual selected-file digest satisfies that boundary. |
|
||||
| CR-02 | FIXED | Complete baseline records and their recomputed digest bind original pre/post/package/resources. The explicit executed `original_member` binds executable size/header/hash. Wrong executable/member and inconsistent inventories are rejected; independently identified writable `copy_post` changes remain allowed. |
|
||||
| CR-03 | FIXED | Scenario validation now checks the actual named copy-pre artifact for both lifetimes and the retained snapshot for retained runs. Previous hash-only reproductions and an isolated retained-snapshot reproduction are rejected; valid named state files still qualify. |
|
||||
| WR-01 | FIXED | Assembly exports the validated ledger projection; readiness compares current/history with the sealed projection. The preparation-to-bundled-renderer check preserves named current/superseded records. The standalone-transfer check needs no source Git checkout, and missing viewer history is rejected. |
|
||||
| WR-02 | FIXED | A real Linux-hosted PowerShell finalizer reproduction recovered an incomplete-only synthetic run as aborted. Initial raw bytes and session identity survived, end clocks remained absent, captured promotion was rejected, and shared validation plus atomic import succeeded with acceptance false. |
|
||||
|
||||
## CR-03 refinement verified
|
||||
|
||||
**Original classification:** BLOCKER
|
||||
**Current disposition:** FIXED by `02d182f35de643f9d68699b2fff1d219dd132edb`, with regression `48fca0d`.
|
||||
**File:** `/home/cristian/codex/Neutron/GamePort/tools/recon/fidelity_receipts.py:667-678`
|
||||
**Related:** `/home/cristian/codex/Neutron/GamePort/tools/recon/fidelity_receipts.py:383-385`
|
||||
|
||||
At `a821754`, `_scenario_observation()` compared continuity digests with named identity strings while the generic validator skipped dictionaries without `path`. The refinement now passes the receipt root to scenario validation and calls `_checked_artifact()` on the actual named state records before comparing digests. The scenario audit and Linux capture matrix both pass their artifact root; their direct test callers were updated as well.
|
||||
|
||||
The bounded reproduction below uses existing synthetic metadata fixtures and launches no game. It previously demonstrated the gap and now demonstrates rejection for both native lifetimes:
|
||||
|
||||
```python
|
||||
from test_fidelity_scenarios import FidelityScenarios
|
||||
import fidelity_receipts as receipts
|
||||
|
||||
fixture = FidelityScenarios()
|
||||
fixture.setUp()
|
||||
try:
|
||||
for lifetime in ('fresh', 'retained'):
|
||||
value, root = fixture.receipt(
|
||||
lifetime + '-natural-ordinary', 'dialogue-return')
|
||||
value['identity']['copy_pre'] = {'sha256': 'f' * 64}
|
||||
value['continuity']['copy_pre_sha256'] = 'f' * 64
|
||||
if lifetime == 'retained':
|
||||
value['identity']['retained_copy'] = {'sha256': 'e' * 64}
|
||||
value['continuity']['retained_copy_sha256'] = 'e' * 64
|
||||
result = receipts.audit_scenarios(
|
||||
fixture.protocol(), [(value, root)])
|
||||
print(lifetime, result['accepted'], result['invalid'])
|
||||
finally:
|
||||
fixture.doCleanups()
|
||||
```
|
||||
|
||||
Run from the repository with `PYTHONPATH=tests:tools/recon`. Earlier output at `a821754` was `fresh 1 []` and `retained 1 []`. Rerunning at `02d182f` gives zero accepted slots and `Reference must be a bounded relative POSIX path` in each invalid list. A third reproduction retaining valid copy-pre but supplying only a hash for `identity.retained_copy` is rejected independently. The unmodified fresh and retained metadata controls each still accept one slot.
|
||||
|
||||
**Additional verification:** Four selected scenario tests passed in **0.424 seconds**: backing-file rejection for both lifetimes, named continuity binding, unrelated retained-snapshot rejection, and complete positive coverage of all 120 metadata slots. The new backing-file test covers hash-only, missing-file and wrong-size state identities, including the retained snapshot. This closes the reported artifact-binding gap without changing the four other verified fixes.
|
||||
|
||||
## Verification evidence and limits
|
||||
|
||||
Read the historical review, fix report and actual source/test diffs for `5569bc2`, `bda35e5`, `6e5ee0b`, `548c97a`, `2608517`, and `a821754`, then the final `48fca0d` regression and `02d182f` refinement. Initially ran 11 selected Python tests in **2.109 seconds**, all passing: selected-file review binding; original executable/member and inventory rejection; mutable generated-copy allowance; complete positive metadata matrix; standalone readiness without Git; malformed viewer history; actual assembled model through its bundled renderer; named pre/retained continuity; and aborted missing-end-clock import. The additional hash-only identity gap discovered during that verification is closed by the independently repeated checks above.
|
||||
|
||||
Separately exercised the actual PowerShell recovery function with a disposable synthetic prepared checkpoint, rejected captured promotion, recovered raw media, compared both raw initial copies byte-for-byte, verified absent end clocks, validated and imported the resulting open aborted receipt. This was Linux-hosted tooling execution, not native Windows evidence.
|
||||
|
||||
No full suite, whole 11,001-file checkpoint readiness/hash walk, original execution or gameplay capture was repeated. The primary's current bundle identities and pending 0/120 human acceptance remain separate evidence; this verification does not promote them. Source and tests were read-only, no commit was made, and unrelated concurrent report edits were preserved.
|
||||
|
||||
Historical `01-REVIEW.md` is unchanged; its SHA-256 is `493c0b9b7b491f7dcc896d6cfda675ced837f56ee32daf2bbf1cd98f1527f74c`.
|
||||
@@ -0,0 +1,60 @@
|
||||
---
|
||||
phase: "01"
|
||||
slug: reproducible-fidelity-baseline
|
||||
status: verified
|
||||
threats_open: 0
|
||||
threats_total: 22
|
||||
threats_closed: 22
|
||||
asvs_level: 1
|
||||
block_on: high
|
||||
register_authored_at_plan_time: true
|
||||
verified_head: 02d182f35de643f9d68699b2fff1d219dd132edb
|
||||
created: "2026-11-13T22:21:09.119266+00:00"
|
||||
---
|
||||
|
||||
# Phase 01 — Security
|
||||
|
||||
The typed security auditor verified all planned mitigation boundaries. The repeated reserved T-01-SC is counted once. All dispositions are mitigate; no accepted or transferred risks.
|
||||
|
||||
## Trust Boundaries
|
||||
|
||||
Originals → generated copies; local paths → file/process operations; media/receipts → review and acceptance; observer → gameplay; transferred checkpoint → immutable validation.
|
||||
|
||||
## Threat Register
|
||||
|
||||
| Threat ID | Category | Severity | Disposition | Mitigation evidence | Status |
|
||||
|---|---|---|---|---|---|
|
||||
| T-01-01 | Tampering | high | mitigate | fidelity_receipts.py:123,221,239,257 | closed |
|
||||
| T-01-02 | Spoofing | high | mitigate | fidelity_receipts.py:275,667,672,714 | closed |
|
||||
| T-01-03 | Tampering | high | mitigate | fidelity_receipts.py:198,212,482,500 | closed |
|
||||
| T-01-04 | Information disclosure | high | mitigate | fidelity_review.py:202,211,219,274 | closed |
|
||||
| T-01-05 | Tampering | high | mitigate | viewer.mjs:2,190; fidelity_review.py:238 | closed |
|
||||
| T-01-06 | Spoofing | medium | mitigate | viewer.mjs:43,79,302,318,324 | closed |
|
||||
| T-01-07 | Spoofing | high | mitigate | fidelity_ledger.py:97,197,203,285 | closed |
|
||||
| T-01-08 | Repudiation | medium | mitigate | fidelity_ledger.py:69,220,299,320 | closed |
|
||||
| T-01-09 | Tampering | medium | mitigate | fidelity_ledger.py:117,339,372 | closed |
|
||||
| T-01-10 | Tampering | high | mitigate | FidelityObservation.cs:54,78,93,109; test_fidelity_observation.py:130 | closed |
|
||||
| T-01-11 | Denial of service | medium | mitigate | FidelityObservation.cs:165,171,179,192,233 | closed |
|
||||
| T-01-12 | Spoofing | high | mitigate | FidelityObservation.cs:47,109,130,166; Program.cs:18,1328 | closed |
|
||||
| T-01-13 | Elevation of privilege | high | mitigate | collect-fidelity-windows.ps1:128,136,144,253,303 | closed |
|
||||
| T-01-14 | Tampering | high | mitigate | fidelity_checkpoint.py:103,120,198,215,220 | closed |
|
||||
| T-01-15 | Spoofing | high | mitigate | collect-fidelity-windows.ps1:176,208,234,285,332 | closed |
|
||||
| T-01-16 | Tampering | high | mitigate | fidelity_capture.py:154,156,195,239,347 | closed |
|
||||
| T-01-17 | Spoofing | high | mitigate | fidelity_capture.py:85,98,107,325,338 | closed |
|
||||
| T-01-18 | Denial of service | medium | mitigate | fidelity_capture.py:30,128,148,202,220,224 | closed |
|
||||
| T-01-19 | Spoofing | high | mitigate | fidelity_acceptance.py:124; fidelity_receipts.py:275,667,672,714; fidelity_capture.py:390 | closed |
|
||||
| T-01-20 | Tampering | high | mitigate | fidelity_receipts.py:453,482,488,494,500 | closed |
|
||||
| T-01-21 | Repudiation | medium | mitigate | fidelity_acceptance.py:127,130,160,184; fidelity_ledger.py:328 | closed |
|
||||
| T-01-SC | Tampering | high | mitigate | fidelity_checkpoint.py:301; collect-fidelity-windows.ps1:253; observer csproj:1 | closed |
|
||||
|
||||
## Accepted Risks Log
|
||||
|
||||
No accepted risks.
|
||||
|
||||
## Security Audit Trail
|
||||
|
||||
Initial source audit identified 20/22 closed and T-01-02/T-01-19 open because hash-only copy identities bypassed file checks. Regression48fca0d reproduced it; fix02d182f validates actual named artifacts at the scenario boundary. Independent auditor reinspection closes both. Code re-review confirms all five findings fixed; see01-REVIEW-VERIFY.md. All191 affected fidelity regressions pass in43.355s.
|
||||
|
||||
## Sign-Off
|
||||
|
||||
All22 planned threats have implemented, verified mitigations; threats_open=0. This tooling verdict does not approve original/native gameplay, physical input, audio or human findings; runtime acceptance remains0/120 OPEN.
|
||||
@@ -1,9 +1,9 @@
|
||||
---
|
||||
phase: "01"
|
||||
slug: "reproducible-fidelity-baseline"
|
||||
status: draft
|
||||
nyquist_compliant: false
|
||||
wave_0_complete: false
|
||||
status: validated
|
||||
nyquist_compliant: true
|
||||
wave_0_complete: true
|
||||
created: "2026-11-12"
|
||||
---
|
||||
|
||||
@@ -13,12 +13,12 @@ created: "2026-11-12"
|
||||
|
||||
| Property | Value |
|
||||
|---|---|
|
||||
| Framework | Existing Python stdlib unittest, standalone .NET 10 console projects; proposed Node built-in tests for pure viewer logic |
|
||||
| Framework | Existing Python stdlib unittest, standalone .NET 10 console projects; Node built-in tests for pure viewer logic |
|
||||
| Config file | Existing scripts/test.sh and scripts/env.sh; no new package dependencies |
|
||||
| Quick run command | `python3 -m unittest discover -s tests -p 'test_fidelity_*.py' -v` (new tests created with their owning slice) |
|
||||
| Viewer quick command | `node --test tests/fidelity-viewer.test.mjs` (new test file created with viewer slice) |
|
||||
| Full suite command | `scripts/test.sh` plus the viewer quick command |
|
||||
| Runtime | Quick target below 30 seconds; measure during execution. Full GPU/original-data suite runs at wave boundaries and has a separate measured duration. |
|
||||
| Quick run command | `python3 -m unittest discover -s tests -p 'test_fidelity_*.py' -v` |
|
||||
| Viewer quick command | `node --test tests/fidelity-viewer.test.mjs` |
|
||||
| Full suite command | `scripts/test.sh` (includes counted Python, Node viewer and managed observer checks) |
|
||||
| Runtime | Broad fidelity run: 40.072 seconds (30-second target exceeded); focused tooling checks typically 1–5 seconds, process/observer checks can take longer. Complete local suite: 782.049626 seconds. |
|
||||
|
||||
## Sampling Rate
|
||||
|
||||
@@ -30,35 +30,35 @@ created: "2026-11-12"
|
||||
|
||||
## Per-Task Verification Map
|
||||
|
||||
Final task bindings below reference the exact executable `<automated>` blocks in the named PLAN.md/task. Each block carries its adjacent observable `<fails_when>`; Python commands assert the minimum discovered count before running. These tests are intended new artifacts, not checks already executed.
|
||||
Final task bindings below reference the exact executable `<automated>` blocks in the named PLAN.md/task. Each block carries its adjacent observable `<fails_when>`; Python commands assert the minimum discovered count before running. The tests exist and have run with positive counts. The status column separates passing automation from actual capture/review still OPEN. Shared EVID requirement acceptance is not implied by any green tooling row.
|
||||
|
||||
| Task | Wave | Exact automated command binding | Minimum count / threat refs |
|
||||
|---|---|---|---|
|
||||
| 01-01-01 | 1 | 01-01-PLAN.md task 01-01-01: counted `test_fidelity_sessions.py` runner and mandated original inventory invocation | 16; T-01-01/02/03 |
|
||||
| 01-01-02 | 1 | 01-01-PLAN.md task 01-01-02: counted `test_fidelity_scenarios.py` runner | 12; T-01-02 |
|
||||
| 01-02-01 | 2 | 01-02-PLAN.md task 01-02-01: counted `test_fidelity_review.py` runner; `node --test tests/fidelity-viewer.test.mjs` | Python 10, Node positive; T-01-04/05/06 |
|
||||
| 01-02-02 | 2 | 01-02-PLAN.md task 01-02-02: `node --test tests/fidelity-viewer.test.mjs` | 16; T-01-04/05/06 |
|
||||
| 01-03-01 | 2 | 01-03-PLAN.md task 01-03-01: counted `test_fidelity_ledger.py` runner | 12; T-01-07/08/09 |
|
||||
| 01-03-02 | 2 | 01-03-PLAN.md task 01-03-02: counted ledger runner; `python3 tools/recon/fidelity_ledger.py validate --ledger docs/evidence/capabilities.json --requirements .planning/REQUIREMENTS.md` | 16 tests, 33 requirements; T-01-07/08/09 |
|
||||
| 01-04-01 | 2 | 01-04-PLAN.md task 01-04-01: exact sourced-SDK observer command and counted `test_fidelity_observation.py` runner | Managed 8, Python 4; T-01-10/11/12 |
|
||||
| 01-04-02 | 2 | 01-04-PLAN.md task 01-04-02: sourced-SDK observer/build and MovementTests/DirectorTests/CheckpointTests/BodyOwnershipTests commands | Managed 14 plus positive existing groups; T-01-10/11/12 |
|
||||
| 01-05-01 | 3 | 01-05-PLAN.md task 01-05-01: counted `test_fidelity_checkpoint.py` runner; `bash -n scripts/prepare-fidelity-checkpoint.sh` | 12; T-01-13/14/15 |
|
||||
| 01-05-02 | 3 | 01-05-PLAN.md task 01-05-02: counted checkpoint runner; package-free PowerShell command deferred to final human session | Python 16, Windows 8; T-01-13/14/15 |
|
||||
| 01-06-01 | 4 | 01-06-PLAN.md task 01-06-01: counted `test_fidelity_capture.py` runner | 10; T-01-16/17/18 |
|
||||
| 01-06-02 | 4 | 01-06-PLAN.md task 01-06-02: counted capture runner and original inventory command | 14; T-01-16/17/18 |
|
||||
| 01-07-01 | 5 | 01-07-PLAN.md task 01-07-01: counted `test_fidelity_acceptance.py` runner; `python3 tools/recon/fidelity_acceptance.py ready --checkpoint dist/fidelity/phase01` | 14; T-01-19/20/21 |
|
||||
| 01-07-02 | 5 | `python3 tools/recon/fidelity_acceptance.py audit --checkpoint dist/fidelity/phase01 --results dist/fidelity/phase01/results --require-complete` | Real matrix/native/original/human checks required; T-01-19/20/21 |
|
||||
| 01-07-03 | 5 | `scripts/test.sh`; `python3 tools/recon/inventory.py ../Original --verify docs/original-manifest.json` | Positive consolidated counts, 539 originals; all threats |
|
||||
| Task | Wave | Exact automated command binding | Minimum count / threat refs | Actual result |
|
||||
|---|---|---|---|---|
|
||||
| 01-01-01 | 1 | 01-01-PLAN.md task 01-01-01: counted `test_fidelity_sessions.py` runner and mandated original inventory invocation | 16; T-01-01/02/03 | green: 29 session tests; 539 originals |
|
||||
| 01-01-02 | 1 | 01-01-PLAN.md task 01-01-02: counted `test_fidelity_scenarios.py` runner | 12; T-01-02 | green: 25 scenario tests |
|
||||
| 01-02-01 | 2 | 01-02-PLAN.md task 01-02-01: counted `test_fidelity_review.py` runner; `node --test tests/fidelity-viewer.test.mjs` | Python 10, Node positive; T-01-04/05/06 | green: 21 review + 27 Node tests |
|
||||
| 01-02-02 | 2 | 01-02-PLAN.md task 01-02-02: `node --test tests/fidelity-viewer.test.mjs` | 16; T-01-04/05/06 | green: 27 Node tests |
|
||||
| 01-03-01 | 2 | 01-03-PLAN.md task 01-03-01: counted `test_fidelity_ledger.py` runner | 12; T-01-07/08/09 | green: 31 ledger tests |
|
||||
| 01-03-02 | 2 | 01-03-PLAN.md task 01-03-02: counted ledger runner; `python3 tools/recon/fidelity_ledger.py validate --ledger docs/evidence/capabilities.json --requirements .planning/REQUIREMENTS.md` | 16 tests, 33 requirements; T-01-07/08/09 | green: 31 tests; 33 requirement mappings validated |
|
||||
| 01-04-01 | 2 | 01-04-PLAN.md task 01-04-01: exact sourced-SDK observer command and counted `test_fidelity_observation.py` runner | Managed 8, Python 4; T-01-10/11/12 | green: 23 managed + 7 process tests |
|
||||
| 01-04-02 | 2 | 01-04-PLAN.md task 01-04-02: sourced-SDK observer/build and MovementTests/DirectorTests/CheckpointTests/BodyOwnershipTests commands | Managed 14 plus positive existing groups; T-01-10/11/12 | green: observer/build and protected groups 28/23/4/3 |
|
||||
| 01-05-01 | 3 | 01-05-PLAN.md task 01-05-01: counted `test_fidelity_checkpoint.py` runner; `bash -n scripts/prepare-fidelity-checkpoint.sh` | 12; T-01-13/14/15 | green: 25 checkpoint tests; shell syntax |
|
||||
| 01-05-02 | 3 | 01-05-PLAN.md task 01-05-02: counted checkpoint runner; package-free PowerShell command deferred to final human session | Python 16, Windows 8; T-01-13/14/15 | green: 25 Python + 18 Linux-hosted PowerShell checks; native Windows session OPEN |
|
||||
| 01-06-01 | 4 | 01-06-PLAN.md task 01-06-01: counted `test_fidelity_capture.py` runner | 10; T-01-16/17/18 | green: 23 capture tests; actual Linux capture OPEN |
|
||||
| 01-06-02 | 4 | 01-06-PLAN.md task 01-06-02: counted capture runner and original inventory command | 14; T-01-16/17/18 | green: 23 capture tests; 539 originals; actual matrix OPEN |
|
||||
| 01-07-01 | 5 | 01-07-PLAN.md task 01-07-01: counted `test_fidelity_acceptance.py` runner; `python3 tools/recon/fidelity_acceptance.py ready --checkpoint dist/fidelity/phase01` | 14; T-01-19/20/21 | green: 29 acceptance tests; readiness exit 0 |
|
||||
| 01-07-02 | 5 | `python3 tools/recon/fidelity_acceptance.py audit --checkpoint dist/fidelity/phase01 --results dist/fidelity/phase01/results --require-complete` | Real matrix/native/original/human checks required; T-01-19/20/21 | OPEN: strict audit exit 1, errors=[], 0/120; fail-closed behavior covered by passing acceptance tests |
|
||||
| 01-07-03 | 5 | `scripts/test.sh`; `python3 tools/recon/inventory.py ../Original --verify docs/original-manifest.json` | Positive consolidated counts, 539 originals; all threats | green: completed full suite exit 0; 539 originals |
|
||||
|
||||
All plan subcommands/paths are explicitly introduced in their owning tasks before verification. Run every focused task command after that task; at integrated checkpoint run the full suite once and repeat only after changes/failures. Quick checks target below 30 seconds, to be measured. Existing full suite and native runs can take longer and record separate durations. No new runtime/fixture/Windows results are claimed here.
|
||||
All 15 task bindings were checked against the seven PLAN verify blocks and SUMMARY interfaces. No missing automated contract was found. Task 01-07-02 remains an explicit actual-evidence dependency; its expected nonzero strict audit is not a green acceptance result. Focused commands ran during their owning slices; the completed integrated suite and subsequent tooling regressions are recorded below. No full suite or large checkpoint hash walk was repeated for this audit.
|
||||
|
||||
The seven explicit classified spec-less boundaries and two unresolved unclassified manual assumptions are reconciled in 01-SOURCE-AUDIT.md. The two research backstop truths abstain to human_needed if actual original audiovisual capture/browser review is insufficient. Descriptor-less project prohibitions remain flagged-unverified, not silently passed. ASVS1 high/critical threats block acceptance; T-01-SC is reserved across plans.
|
||||
|
||||
## Wave 0 Requirements
|
||||
## Wave 0 Requirements — Complete (Automation)
|
||||
|
||||
- Each implementation slice creates meaningful tests together with its production code; no empty stubs counted as validation.
|
||||
- Create fidelity test fixtures covering changed/missing/added originals, output overlap, symlink/drive/case escape, reused session, tampered hash, invalid marker and unsupported schema.
|
||||
- Create pure viewer tests including asymmetric durations, missing/buffering tracks, preserved playbackRate 1.0 and exclusive audio switching.
|
||||
- Implemented fidelity test fixtures covering changed/missing/added originals, output overlap, symlink/drive/case escape, reused session, tampered hash, invalid marker and unsupported schema.
|
||||
- Implemented pure viewer tests including asymmetric durations, missing/buffering tracks, preserved playbackRate 1.0 and exclusive audio switching.
|
||||
- No external test-framework installation required. Existing full suite remains available.
|
||||
|
||||
## Manual-Only Verifications
|
||||
@@ -72,14 +72,39 @@ The seven explicit classified spec-less boundaries and two unresolved unclassifi
|
||||
|
||||
Unavailable/failed executions are recorded as open dependencies. Completing tools or preparing a bundle does not close EVID-02/EVID-04 or mark Phase 1 accepted. Source-backed later work may continue only under the existing roadmap exception.
|
||||
|
||||
## Measured Verification Evidence
|
||||
|
||||
- Completed integrated run: `artifacts/fidelity/01-07-full-suite.json` and `.log`, exit 0 in **782.049626 seconds**. Actual output records 556 Python tests (180 fidelity), 27 Node tests, 23 standalone managed observer checks, two separate HUD tests, all 51 managed entry-point invocations/build, 36 rendered Vulkan receipts with zero reported validation errors, SDL dummy-audio checks and 539 unchanged originals. Optional native-window checks were not enabled. Dummy audio does not establish audibility.
|
||||
- Subsequent code-review fixes: `01-FIX-REPORT.md` and `artifacts/fidelity/01-review-fixes/`. `python-fidelity.log` records **189 passing tests in 40.072 seconds**; `acceptance-final.log` records **29 passing acceptance tests** after the final standalone-transfer regression. These runs overlap; do not add their counts. `node-viewer-direct.log` records 27 behavior tests, `powershell.log` 18 synthetic checks under Linux-hosted PowerShell, and `original-preservation.log` 539 unchanged originals. The initial sandbox socket errors were resolved by the scoped local run; they are not represented as passes.
|
||||
- Current discovery, without executing runtime loops: acceptance 29, capture 23, checkpoint 25, ledger 31, observation 7, review 21, scenarios 25, sessions 29: **190 current fidelity tests**. The final added acceptance test explains the difference from the earlier 189-test aggregate; it was executed in the final 29-test acceptance run. Discovery alone is not execution evidence.
|
||||
- Review fixes exercise selected-receipt digest binding, pristine executable/inventory identity, named copy-state lifetime binding, sealed ledger/history projection including standalone transfer, and incomplete-session recovery without captured promotion. They strengthen existing covered contracts; independent review remains separate.
|
||||
- Fresh immutable checkpoint: **11001 members**, `dist/fidelity/phase01`. Saved `01-review-fixes/readiness.json` reports `materials_ready: true`, `acceptance: human_needed` (command exit 0). Saved `acceptance.json` reports `errors: []`, **0/120**, all ten human findings pending (strict command exit 1). Original-DxWnd, native Windows and native Linux each retain 40 outstanding obligations.
|
||||
- Focused tooling feedback is generally around 1–5 seconds (session/scenario/ledger around one second, checkpoint 4.742 seconds, review 5.234 seconds in owning summaries); observer process integration measured 19.126 seconds. The broad 40.072-second regression **exceeds** the proposed 30-second quick target. This is a latency WARNING, not a missing behavioral check or evidence acceptance.
|
||||
|
||||
## Validation Sign-Off
|
||||
|
||||
- [ ] Final plans bind every task to automated checks or explicit human/native evidence
|
||||
- [ ] Sampling continuity has no three consecutive tasks without automated verification
|
||||
- [ ] New test files exist and execute nonzero test counts
|
||||
- [ ] No watch-mode flags
|
||||
- [ ] Quick feedback latency measured below 30 seconds
|
||||
- [ ] Native/original capture limitations recorded
|
||||
- [ ] nyquist_compliant updated only after the implemented validation contract is audited
|
||||
- [x] Final plans bind every task to automated checks or explicit human/native evidence
|
||||
- [x] Sampling continuity has no three consecutive tasks without automated verification
|
||||
- [x] New test files exist and execute nonzero test counts
|
||||
- [x] No watch-mode flags
|
||||
- [ ] Broad quick feedback below 30 seconds — measured 40.072 seconds; WARNING retained
|
||||
- [x] Native/original capture limitations recorded
|
||||
- [x] Implemented automated validation contract audited; `nyquist_compliant` and `wave_0_complete` refer only to automation coverage
|
||||
- [ ] Actual combined capture and human review complete — OPEN
|
||||
- [ ] EVID requirements and Phase 01 acceptance complete — OPEN
|
||||
|
||||
**Approval:** Pending execution; final task bindings are planned, while nyquist_compliant and wave_0_complete remain false until actual implementation and validation are audited.
|
||||
**Automation validation:** Validated on 2026-11-13 from executed tests and retained logs; no new automated gap found, no tests or implementation changed. The latency target remains a documented warning. `status: validated` does not advance the phase or promote any EVID requirement.
|
||||
|
||||
**Acceptance dependencies:** A1, A2, EVID-02-unclassified, EVID-04-unclassified, P1, P2, P3, browser, paired_review and physical_input remain OPEN. Follow the single combined agenda in `docs/evidence/checkpoint-session.md` and its Windows/Linux session procedures. Collect actual original-DxWnd/native Windows/native Linux recordings, physical input and audible checks, review real paired playback, return the identified local results, then rerun strict acceptance. The Linux preflight's missing usable display/audio is an explicit dependency. Cross-publish, Wine, headless/synthetic fixtures and preparation cannot close it. Independent review/security gates remain owned by their respective audits.
|
||||
|
||||
## Final copy-state refinement
|
||||
|
||||
All191 fidelity checks pass in43.355s after02d182f (26 scenario,23 capture,29 acceptance); missing/hash-only/wrong-size state records are explicitly rejected for both lifetimes. The43.355s aggregate still exceeds the30s quick target. No manual acceptance was promoted.
|
||||
|
||||
## Validation Audit 2026-11-13
|
||||
|
||||
| Metric | Count |
|
||||
|---|---|
|
||||
| Gaps found | 0 |
|
||||
| Resolved | 0 |
|
||||
| Escalated | 0 |
|
||||
@@ -1,3 +1,5 @@
|
||||
<!-- CONSUMED: task3 recovered exit0 and review complete through02d182f. Current next action: final phase verification, then combined human session; never resume historical active test below. -->
|
||||
|
||||
# Active quota checkpoint — 01-07, resume task3 verification
|
||||
|
||||
This active handoff **takes precedence over01-07SUMMARY existence**. That summary
|
||||
|
||||
Reference in new issue
Block a user