Fix orbit camera mirroring by matching gameplay handedness
This commit is contained in:
1 parent
1b679c641a
commit
d8f1b51c86
10 files changed
+125
-4
No files matched your search
@@ -3,6 +3,12 @@
|
||||
Compilation, native runtime, original behavior and full feature completion are
|
||||
separate evidence categories. **The game is not fully reconstructed/playable yet.**
|
||||
|
||||
Orbit inspector follow-up: corrected right-handed inspection view/perspective
|
||||
to gameplay's positive-Z left-handed convention.36 camera/aspect cases and all
|
||||
existing projection checks pass. Enabled-validation llvmpipe captures confirm
|
||||
the removed horizontal reflection; lab gameplay captures are byte-identical.
|
||||
Native/package evidence: orbit-camera.md. Native Windows remains unverified.
|
||||
|
||||
Rocketship impact follow-up: corrected first-material red-flash RGBA previously
|
||||
misapplied to ship scale.13 managed groups include actual wall contact plus130
|
||||
frames of unchanged geometry, correct ship-only tint, recovery and repeated
|
||||
|
||||
@@ -264,3 +264,9 @@
|
||||
actual DLL renderer consumers now guard the contract. Use a ship-only red
|
||||
material flash with unit geometry; regress vertex positions as well as values.
|
||||
See gameplay/rocketship-impact-render.md.
|
||||
45. **Keep inspection in the gameplay coordinate convention.** A right-handed
|
||||
view/perspective pair can render a valid frame while mirroring a positive-Z
|
||||
source scene relative to gameplay. OrbitCamera now owns the matching
|
||||
left-handed view/projection; apply the shared Vulkan Y correction only once.
|
||||
Regress screen right/up and depth across camera poses, not frame presence
|
||||
alone. The modern inspector is separate from recovered original camera logic.
|
||||
@@ -0,0 +1,38 @@
|
||||
# Orbit camera handedness correction
|
||||
|
||||
2026-11-03. User reports the world flips when using orbit inspection.
|
||||
This is a modern camera bug; no new original-binary interpretation is needed.
|
||||
|
||||
## Cause and correction
|
||||
|
||||
Program used System.Numerics CreateLookAt/CreatePerspectiveFieldOfView for
|
||||
inspection, both right-handed. Gameplay and source geometry use positive-Z
|
||||
left-handed camera space. At the same eye/target/up, swapping the paired view
|
||||
and perspective conventions reverses screen X. The old orbit view therefore
|
||||
mirrored the world relative to gameplay. Vulkan's shared M22 viewport flip is
|
||||
still required for screen Y; removing that would introduce another inversion.
|
||||
|
||||
OrbitCamera now owns the inspector eye/view/projection calculation and uses
|
||||
CreateLookAtLeftHanded/CreatePerspectiveFieldOfViewLeftHanded. The caller applies
|
||||
the same single Vulkan Y correction as gameplay. Existing orbit positions,
|
||||
elevation limits, zoom, field of view and depth range are retained. Gameplay,
|
||||
scripted and Rocketship cameras keep their existing math.
|
||||
|
||||
## Verification
|
||||
|
||||
ProjectionTests covers36 combinations of four azimuths, three elevations and
|
||||
three aspect ratios (4:3,16:9,21:9). Tests independently construct forward/right/up
|
||||
vectors and verify centered target, screen directions, positive-Z forward and
|
||||
Vulkan0..1 near/far depth. Existing all35 level clip mappings and actual outside
|
||||
geometry regression also pass. Main .NET build passes.
|
||||
|
||||
Before/after960×720 llvmpipe model captures show the horizontal reflection;
|
||||
mirroring the old image matches the corrected view to under.0012 mean intensity
|
||||
per RGB channel, versus2.68–4.77 without reflection. Both runs enable Vulkan
|
||||
validation and report zero errors. Captures were inspected. The two-frame lab
|
||||
gameplay readbacks before/after are byte-identical with the same copied assets.
|
||||
Generated evidence: artifacts/orbit-camera/{projection.log,build.log,before.log,
|
||||
after.log,comparison.log,comparison.png,gameplay-before.log,gameplay-after.log}.
|
||||
The first test compile had an ambiguous target-typed Vector4 overload; specifying
|
||||
Vector4 fixed it before validation. Package/native window results follow after
|
||||
rebuild; native Windows remains a separate runtime check.
|
||||
@@ -1,5 +1,17 @@
|
||||
# Progress — 2026-11-03
|
||||
|
||||
## Orbit camera reflection correction
|
||||
|
||||
The modern inspector paired a right-handed view/perspective with source scenes
|
||||
whose gameplay cameras use positive-Z left-handed space. This mirrored the world
|
||||
on switching camera modes. OrbitCamera now supplies the matching left-handed
|
||||
view/projection and retains the shared single Vulkan Y correction.36 camera/
|
||||
aspect matrix cases pass plus existing35-level projection checks. Before/after
|
||||
GPU captures confirm the removed reflection; lab gameplay captures remain
|
||||
byte-identical. Main build passes. Native/package evidence is recorded in
|
||||
[orbit-camera.md](orbit-camera.md). This is a port camera fix, not new original
|
||||
runtime evidence.
|
||||
|
||||
## Rocketship wall-impact correction
|
||||
|
||||
User Windows testing exposed wild ship scaling on wall hits. The initial port
|
||||
|
||||
@@ -3,6 +3,10 @@
|
||||
Original API and state maps: `analysis/graphics.md`. Mesh/material/texture formats:
|
||||
`file-formats.md`. Vulkan code: `src/GamePort/Rendering/Vulkan/VulkanRenderer.cs`.
|
||||
|
||||
Modern orbit inspection uses gameplay's positive-Z left-handed view/perspective
|
||||
and the same single Vulkan viewport Y correction. The former right-handed pair
|
||||
mirrored the scene when changing modes; regression and GPU proof: orbit-camera.md.
|
||||
|
||||
Default prepared LV1B view uses the GAM STARTEXP camera; positive-Z projection
|
||||
uses recovered FOV `0xAAA/16384*360` degrees, near 20, far 10000. Generic engine
|
||||
far default is 3200; other scene-specific overrides remain to be mapped. Camera
|
||||
|
||||
@@ -46,6 +46,9 @@ compile, runtime and original-fidelity verification are separate.
|
||||
|
||||
## Immediate continuation
|
||||
|
||||
- [x] Correct orbit inspection's mirrored world: share gameplay handedness,
|
||||
verify36 angle/elevation/aspect cases, GPU reflection and unchanged gameplay.
|
||||
|
||||
- [x] Correct user-reported Rocketship wall scaling: recover material RGBA
|
||||
consumer, replace geometry deformation with red damage flash, regress actual
|
||||
wall contact/per-vertex geometry/color through repeated impacts and expiry.
|
||||
|
||||
Reference in new issue
Block a user