Fix orbit camera mirroring by matching gameplay handedness

This commit is contained in:
UnixNight committed 2026-11-03 17:38:48 -05:00
1 parent 1b679c641a
commit d8f1b51c86
10 files changed
+125 -4

No files matched your search

+29
View File
@@ -64,6 +64,35 @@ Require(recovered > 100, "Actual outside geometry must demonstrate the old arbit
Console.WriteLine($"PASS actual LEV1 source view retains{recovered} vertices formerly beyond the incorrect3200 far plane");
Console.WriteLine("Projection recovery is statically verified; original-game visual comparison and per-layer/fog fidelity remain separate.");
//The modern inspector must preserve gameplay's screen directions instead of
//reflecting the original left-handed scene through a right-handed camera.
foreach(var aspect in new[]{4f/3,16f/9,21f/9})
foreach(var angle in new[]{0,MathF.PI/2,MathF.PI,MathF.PI*1.5f})
foreach(var elevation in new[]{-.7f,0,.7f})
{
var target=new Vector3(123,456,-789);
const float radius=600;
var orbit=OrbitCamera.Create(target,radius,angle,elevation,aspect);
var forward=Vector3.Normalize(target-orbit.Eye);
var right=Vector3.Normalize(Vector3.Cross(Vector3.UnitY,forward));
var up=Vector3.Cross(forward,right);
var projection=orbit.Projection;projection.M22*=-1;
Vector3 Screen(Vector3 point)
{
var clip=Vector4.Transform(new Vector4(point,1),orbit.View*projection);
Require(clip.W>0,"Orbit target lies in front of positive-Z view");
return new(clip.X/clip.W,clip.Y/clip.W,clip.Z/clip.W);
}
var center=Screen(target);var screenRight=Screen(target+right*40);var screenUp=Screen(target+up*40);
Require(MathF.Abs(center.X)<.00001f&&MathF.Abs(center.Y)<.00001f,"Orbit target stays centered");
Require(screenRight.X>center.X&&screenUp.Y<center.Y,"Orbit preserves gameplay right/up after Vulkan viewport flip");
var inView=Vector3.Transform(target,orbit.View);
Require(MathF.Abs(inView.Z-radius)<.001f,"Orbit view uses gameplay positive-Z forward");
var near=Screen(orbit.Eye+forward*.06f);var far=Screen(orbit.Eye+forward*12000);
Require(MathF.Abs(near.Z)<.003f&&MathF.Abs(far.Z-1)<.00001f,"Orbit near/far retain Vulkan0..1 depth");
}
Console.WriteLine("PASS orbit uses gameplay handedness/right/up/depth across36 camera poses and aspect ratios");
void Bytes(int address, string expected)
{
var bytes = Convert.FromHexString(expected);