Files
Neutron/docs/gameplay/bubble-implementation-review.md

4.9 KiB

Bubble implementation review

2026-11-02. Independent source review of the current integration against bubble.md, bubble-motion.md, bubble-body.md, bubble-rendering.md and their recorded source contracts. Read-only inspection of runtime/test files; this report is the reviewer's only edited file. No new binary recovery or original-game execution was performed. No blocking implementation mismatch was found within the declared bounded profile.

Checked contracts

Contract / source evidence Current implementation
Equip429049..429085 and cleanup428037..4280BB LabSimulation.GadgetMode sets raw0/movement2, radius160/factor.415/max1350, preserves root/queued body state, and rejects existing effect flags. Cleanup restores60/1.265/mode0 and source max650, calls Stop and separately clears expansion.
Input426084 then drain426264..42629F and placement4262A5..4263DA StepInput updates steering/camera, adjusts shared energy, performs depletion cleanup, then captures BubbleRoot from the resulting camera eye even when that cleanup changed mode. Rendering consumes this stored root.
Input/Jimmy/Bubble partial order Fresh Step schedules input before the player and owned effect afterward; retained-order policy places input after the effect. Effect time advances without raw input ownership. Retained helper lifetime is still an explicit inference.
Mode2 apply4387E0 and input439900 Fire supplies throttle while ordinary beam/jetpack dispatch is suppressed. Supported input decay and later scalar halving remain separate. Bounce assigns liveY300/900 after XZ composition, publishes the post-half scalar, retains mode2 and requests106 only for held jump.
Supported wrapper42469B..4246E9 Supported Bubble retains radius160 and STOP; equip/cleanup do not directly recenter the actor root. The fixed75.9 render bridge remains a stated modern boundary.
Body479D20/support47B890 Current radius/factor reach OriginalBodyPhysics. Production admission remains VR01/VR04; lab/outside retain their prior capsule adapter. No dynamic actor or generic special wall policy is newly implied.
Retained polygon338 →462520→44E030 Successful source support updates retained material independently of current support. Actual VR01 profile0..4/111 runs before the controller gate, including airborne/uncontrolled ticks; Bubble skips the specific damage callback but preserves entry39 and the latch. Cleanup permits damage on the retained111 without replaying entry sounds.
Late lava4257D6..4257EE Float timer persistence is separated from the unrounded strict>4 comparison and pulse input. Vr01FloorState.Step runs after Invisible's material requests; stored PlayerAppearance prevents a fresh Invisible snapshot from erasing late RGBA.
Source practice428F61..428FCA Bubble practice selection updates display selection and requests the scene without starting live body/effect setup. GadgetScreen and cleanup use raw mode separately from display selection, including rejected Invisible equip.
Sprite410AE0/410CA0/410D00 Independent flags, active/expanding/collapsing priority, strict fade boundaries, full RGBA, retained dimensions and original Canv1 pixels remain intact in effect/visual components.

Verification

Reviewer reran from GamePort/, with the local SDK environment and --no-restore:

  • dotnet run --project tests/GamePort.BubbleTests:13 groups passed, including six copied-original numeric body references and actual VR01 retained111.
  • dotnet run --project tests/GamePort.BubbleMotionTests:11 groups passed.
  • dotnet run --project tests/GamePort.BubbleVisualTests:8 groups passed.

These are managed source-projection/integration checks. They do not establish whole original-game behavior, GPU appearance, sound audibility or native Windows runtime compatibility. Full-suite, packaging and presentation results belong to the primary integration report.

Remaining boundaries and useful follow-up

The declared TracksBubbleOrientation profile preserves the prior yaw-only baseline before first Bubble use. Its destination handoff follows the recovered conditional ground/ordinary-air contracts; shared generic interpolation enable, dirty flags and transform scheduling remain open. The source camera adapter, mouse/analog extensions, complete retained-helper lifetime, other damage flags, footstep-loop ownership, dynamic pairs and broader special contacts likewise remain open. No universal hazard immunity or original visual parity follows from this slice.

Optional future regression strengthening: assert the exact captured-root formula against the post-input camera eye, and explicitly compare fresh versus retained input scheduling at an effect start/cleanup boundary. Current code follows those orders, but existing frozen-root/independent-clock assertions cover only part of that contract. No extra runtime code or new tests were added during this review.