76 lines
6.4 KiB
Markdown
76 lines
6.4 KiB
Markdown
---
|
|
phase: 01-reproducible-fidelity-baseline
|
|
verified: 2026-11-13T22:19:18Z
|
|
review_path: .planning/phases/01-reproducible-fidelity-baseline/01-REVIEW.md
|
|
fix_report_path: .planning/phases/01-reproducible-fidelity-baseline/01-FIX-REPORT.md
|
|
verified_head: 02d182f35de643f9d68699b2fff1d219dd132edb
|
|
findings_verified: 5
|
|
fixed: 5
|
|
open: 0
|
|
findings:
|
|
critical: 0
|
|
warning: 0
|
|
info: 0
|
|
total: 0
|
|
status: clean
|
|
---
|
|
|
|
# Phase 01 review-fix verification
|
|
|
|
All five fixes are verified. The final CR-03 refinement requires actual backing artifacts for named copy-state identities and rejects the hash-only records that survived its first fix. No reviewed finding remains open.
|
|
|
|
| Finding | Disposition | Independent verification |
|
|
|---|---|---|
|
|
| CR-01 | FIXED | The selected path is retained and its own digest is compared with the human finding. The sibling-digest and absent-digest regressions leave human checks pending; the actual selected-file digest satisfies that boundary. |
|
|
| CR-02 | FIXED | Complete baseline records and their recomputed digest bind original pre/post/package/resources. The explicit executed `original_member` binds executable size/header/hash. Wrong executable/member and inconsistent inventories are rejected; independently identified writable `copy_post` changes remain allowed. |
|
|
| CR-03 | FIXED | Scenario validation now checks the actual named copy-pre artifact for both lifetimes and the retained snapshot for retained runs. Previous hash-only reproductions and an isolated retained-snapshot reproduction are rejected; valid named state files still qualify. |
|
|
| WR-01 | FIXED | Assembly exports the validated ledger projection; readiness compares current/history with the sealed projection. The preparation-to-bundled-renderer check preserves named current/superseded records. The standalone-transfer check needs no source Git checkout, and missing viewer history is rejected. |
|
|
| WR-02 | FIXED | A real Linux-hosted PowerShell finalizer reproduction recovered an incomplete-only synthetic run as aborted. Initial raw bytes and session identity survived, end clocks remained absent, captured promotion was rejected, and shared validation plus atomic import succeeded with acceptance false. |
|
|
|
|
## CR-03 refinement verified
|
|
|
|
**Original classification:** BLOCKER
|
|
**Current disposition:** FIXED by `02d182f35de643f9d68699b2fff1d219dd132edb`, with regression `48fca0d`.
|
|
**File:** `/home/cristian/codex/Neutron/GamePort/tools/recon/fidelity_receipts.py:667-678`
|
|
**Related:** `/home/cristian/codex/Neutron/GamePort/tools/recon/fidelity_receipts.py:383-385`
|
|
|
|
At `a821754`, `_scenario_observation()` compared continuity digests with named identity strings while the generic validator skipped dictionaries without `path`. The refinement now passes the receipt root to scenario validation and calls `_checked_artifact()` on the actual named state records before comparing digests. The scenario audit and Linux capture matrix both pass their artifact root; their direct test callers were updated as well.
|
|
|
|
The bounded reproduction below uses existing synthetic metadata fixtures and launches no game. It previously demonstrated the gap and now demonstrates rejection for both native lifetimes:
|
|
|
|
```python
|
|
from test_fidelity_scenarios import FidelityScenarios
|
|
import fidelity_receipts as receipts
|
|
|
|
fixture = FidelityScenarios()
|
|
fixture.setUp()
|
|
try:
|
|
for lifetime in ('fresh', 'retained'):
|
|
value, root = fixture.receipt(
|
|
lifetime + '-natural-ordinary', 'dialogue-return')
|
|
value['identity']['copy_pre'] = {'sha256': 'f' * 64}
|
|
value['continuity']['copy_pre_sha256'] = 'f' * 64
|
|
if lifetime == 'retained':
|
|
value['identity']['retained_copy'] = {'sha256': 'e' * 64}
|
|
value['continuity']['retained_copy_sha256'] = 'e' * 64
|
|
result = receipts.audit_scenarios(
|
|
fixture.protocol(), [(value, root)])
|
|
print(lifetime, result['accepted'], result['invalid'])
|
|
finally:
|
|
fixture.doCleanups()
|
|
```
|
|
|
|
Run from the repository with `PYTHONPATH=tests:tools/recon`. Earlier output at `a821754` was `fresh 1 []` and `retained 1 []`. Rerunning at `02d182f` gives zero accepted slots and `Reference must be a bounded relative POSIX path` in each invalid list. A third reproduction retaining valid copy-pre but supplying only a hash for `identity.retained_copy` is rejected independently. The unmodified fresh and retained metadata controls each still accept one slot.
|
|
|
|
**Additional verification:** Four selected scenario tests passed in **0.424 seconds**: backing-file rejection for both lifetimes, named continuity binding, unrelated retained-snapshot rejection, and complete positive coverage of all 120 metadata slots. The new backing-file test covers hash-only, missing-file and wrong-size state identities, including the retained snapshot. This closes the reported artifact-binding gap without changing the four other verified fixes.
|
|
|
|
## Verification evidence and limits
|
|
|
|
Read the historical review, fix report and actual source/test diffs for `5569bc2`, `bda35e5`, `6e5ee0b`, `548c97a`, `2608517`, and `a821754`, then the final `48fca0d` regression and `02d182f` refinement. Initially ran 11 selected Python tests in **2.109 seconds**, all passing: selected-file review binding; original executable/member and inventory rejection; mutable generated-copy allowance; complete positive metadata matrix; standalone readiness without Git; malformed viewer history; actual assembled model through its bundled renderer; named pre/retained continuity; and aborted missing-end-clock import. The additional hash-only identity gap discovered during that verification is closed by the independently repeated checks above.
|
|
|
|
Separately exercised the actual PowerShell recovery function with a disposable synthetic prepared checkpoint, rejected captured promotion, recovered raw media, compared both raw initial copies byte-for-byte, verified absent end clocks, validated and imported the resulting open aborted receipt. This was Linux-hosted tooling execution, not native Windows evidence.
|
|
|
|
No full suite, whole 11,001-file checkpoint readiness/hash walk, original execution or gameplay capture was repeated. The primary's current bundle identities and pending 0/120 human acceptance remain separate evidence; this verification does not promote them. Source and tests were read-only, no commit was made, and unrelated concurrent report edits were preserved.
|
|
|
|
Historical `01-REVIEW.md` is unchanged; its SHA-256 is `493c0b9b7b491f7dcc896d6cfda675ced837f56ee32daf2bbf1cd98f1527f74c`.
|