6.5 KiB
Invisible implementation review
2026-11-01. Independent read-only review of the primary's current Invisible/energy runtime against invisible.md, retained companion/preparation evidence and the original42A920 instructions. Reviewed files: InvisibleGadget, PlayerEnergy, LabSimulation, PlayerSceneBinding, PlayerGadgetMaterial, SceneDirector, ActorPatrol, Program and InvisibleTests. The reviewer edits only this report; primary owns fixes and integration.
Directly evidenced correction found and resolved
The initial SceneDirector only released gadgets through current raw-owner438 preparation. Original CAM4165B7..4165DC and MCA43129A..4312CC separately inspect DeactivateInv and look up JIM1, even when the controlled pointer is already NULL or another actor owns it. Both constructors default the property1; absent GAM data does not mean false. MCA's prelude runs before its first target-none branch. The initial implementation could therefore retain active Invisible through a CAM/MCA where original code cleans it.
Primary added GadgetReleaseRequested with an explicit JIM1 lookup and Integer("DeactivateInv",1) at single-CAM/initial-MCA activation, before target/ skip checks. PlayerSceneBinding subscribes and uses existing selected-gadget cleanup. Re-reading confirms that correction is present. Existing ordered raw 438/410/flatten preparation remains separate. Later MCA shot changes do not repeat the initial prelude. AI-null still dispatches410 without invented438/ gadget cleanup; its raw-null pause can retain Invisible state as source does.
Confirmed source alignment
- Invisible runs immediately after the player movement phase and before the existing owned effect phase. AnyControlled is passed separately from Jimmy input ownership. Null raw control freezes timers/hides the meter; a different nonnull owner can permit the wrapper without permitting Jimmy movement.
- Equip accepts energy>0 or VR override. Display selection2 is retained even when the actual raw-mode equip rejects; caller cleanup removes the old special mode first. Successful equip resets both clocks0. Unequip stores remaining7, recharge0 and restores opaque/targetable presentation; modern full reset starts0 and clears diagnostic counts explicitly.
- Activation uses remaining0 and recharge exactly7, primary without jump, energy strictly>2 or override, one fixed−2 adjustment and same-call remaining decrement. Initial recharge must complete first; reaching7 cannot activate until the next invocation. Held primary can reactivate after another recharge.
- Recharge runs only with remaining0 and positive energy/override, clamps7 and turns the meter white. Expiry<=0 restores opaque/targetable/red; recharge starts next call. Active duration continues at zero energy or during jumps.
- Opacity0.7, additive initial branch and last3s alternating conventional/ additive blend match the guarded material path. Expiry argument0 means reset material alpha1/blend-disabled, not alpha0. The one-atlas Jimmy draw keeps authored visibility and geometry; no invented whole-model hide/fade is used.
- PlayerEnergy implements strict19/20 warning hysteresis, empty-crossing sound80 before the scalar write, low182 after the write/before latch and VR01..08 helper bypass. The scalar and warning latch share a session owner across ordinary loads; raw saved/debug scalar assignment does not rearm the helper. The upper clamp compares the pre-store sum, and callback-driven scalar changes are respected by reloading after the crossing callback, as source42A975 does.
- Companion hide/disable occurs on equip, including recharge, not on activation. The binding preserves distinct AI activation, body-enable and movement-enable fields. Its six-level restore exclusion matches the bounded PostLoad9E8 mapping; it does not restore a saved previous visibility or blanket-pause AI.
Explicit remaining boundaries
- The pure Invisible suppressor branch is implemented/tested, but LabSimulation currently supplies no provider for source global4F8182, nor the primary helper's independent4F83E0 veto. Modern modal/focus/debug capture clears input/pauses simulation. Those policies do not establish the complete original global suppression lifecycle; document this as partial input coverage.
- Source55D/49D target eligibility is stored/observable, but full enemy sensing, lost-target, existing attack and class-specific consumers are absent. Generic 409CC0 also permits positive enemy934 when the flag is false. Do not describe the slice as universal enemy avoidance or invulnerability.
- Companion9E8 is represented by known initial level policy. Later source setters/dynamic modes remain outside this bridge. MovementEnabled is stored but has no independent modern consumer yet; the bounded equip/cleanup path writes it together with BodyEnabled, which gates body integration. Independent changes to only one flag require their original consumers before expansion.
- Additive is the declared graphics509A13=false branch. The original setting predicate, general multi-material/LOD behavior, transparent depth state, original registry cadence and exhaustive x87 meter boundaries remain open. Existing full-panel/noclip pauses and full scene rebuild are modern policies.
- Meter resources/layout are being integrated by primary from the independent asset report. This review does not certify that unfinished overlay or final native/packaged renders. Full game and native Windows comparison remain open.
Verification
The reviewer independently ran the current twelve managed Invisible/energy groups
successfully using the existing project SDK, logged in
artifacts/invisible/runtime-review-tests.log. That run covers energy callback
ordering/hysteresis/retention/tutorial bypass, first recharge, activation strict
threshold/jump, raw-null/suppressor pause, flash/expiry, repeated held activation,
cleanup and material mapping. It predates the primary's additional binding/
companion fixtures. Nine source/static-projection groups independently pass in
artifacts/invisible/tests.log; these do not execute original code.
Final integration should retain explicit fixtures for raw-other-owner activation without Jimmy movement, AI-null freeze, named-Jimmy CAM/MCA cleanup while already raw-null, DeactivateInv default/explicit0, failed equip/display separation and companion restore restrictions. Primary owns those runtime additions and the complete suite, actual SDL/GPU input/readback, builds and release evidence.